[all-commits] [llvm/llvm-project] 5082ac: [compiler-rt] Add custom libc++ workaround for CMa...

Alexander Richardson via All-commits all-commits at lists.llvm.org
Sun Nov 10 20:30:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5082acce4fd3646d5760c02b2c21d9cd2a1d7130
      https://github.com/llvm/llvm-project/commit/5082acce4fd3646d5760c02b2c21d9cd2a1d7130
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M compiler-rt/cmake/Modules/AddCompilerRT.cmake
    M compiler-rt/lib/fuzzer/CMakeLists.txt
    M compiler-rt/lib/fuzzer/tests/CMakeLists.txt
    M compiler-rt/lib/msan/tests/CMakeLists.txt
    M compiler-rt/lib/tsan/CMakeLists.txt

  Log Message:
  -----------
  [compiler-rt] Add custom libc++ workaround for CMake < 3.26

The INSTALL_BYPRODUCTS ExternalProject_Add() argument was only added in
CMake 3.26 and the current minimum is 3.20. Work around this by using an
explicit ExternalProject_Add_Step() call for the install step with a
BYPRODUCTS argument. We can't keep using the `install` name here since that
is reserved by the CMake implementation and results in errors when used.

This commit should be reverted once LLVM depends on CMake 3.26.

Pull Request: https://github.com/llvm/llvm-project/pull/115677



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list