[all-commits] [llvm/llvm-project] 247e4d: [mlir][IR][NFC] `DominanceInfo`: Share same impl f...

Matthias Springer via All-commits all-commits at lists.llvm.org
Sat Nov 9 22:24:11 PST 2024


  Branch: refs/heads/users/matthias-springer/block_dom
  Home:   https://github.com/llvm/llvm-project
  Commit: 247e4db0cef5c0ce2f15bba482b1214ab4fabc5c
      https://github.com/llvm/llvm-project/commit/247e4db0cef5c0ce2f15bba482b1214ab4fabc5c
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp

  Log Message:
  -----------
  [mlir][IR][NFC] `DominanceInfo`: Share same impl for block/op dominance

The `properlyDominates` implementations for blocks and ops are very similar. This commit replaces them with a single implementation that operates on block iterators. That implementation can be used to implement both `properlyDominates` variants.

Note: A subsequent commit will add a new public `properlyDominates` overload that accepts block iterators. That functionality can then be used to find a valid insertion point at which a range of values is defined (by utilizing post dominance).

Depends on #115433.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list