[all-commits] [llvm/llvm-project] e4c141: [mlir][IR] `DominanceInfo`: Fix inconsistency in p...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e4c14190bb097162e15cd5822b3de97ea7bac0d6
      https://github.com/llvm/llvm-project/commit/e4c14190bb097162e15cd5822b3de97ea7bac0d6
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp
    M mlir/test/Analysis/test-dominance.mlir
    M mlir/test/lib/IR/TestDominance.cpp

  Log Message:
  -----------
  [mlir][IR] `DominanceInfo`: Fix inconsistency in proper block/op dominance (#115413)

An operation is considered to properly dominate itself in a graph
region. That's because there is no concept of "dominance" in a graph
region. (`dominates` returns "true" for all pairs of ops in the same
block. It makes sense to do the same for `properlyDominates`.)

Previously, a block was *not* considered to dominate itself in a graph
region. This commit fixes this asymmetry between ops and blocks: both
are now properly dominating themselves in a graph region.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications