[all-commits] [llvm/llvm-project] 2052c6: [mlir][IR] Fix inconsistency in block/op dominance

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/properly_dominate
  Home:   https://github.com/llvm/llvm-project
  Commit: 2052c653614d58b100ee467c13a1630035e6cb8b
      https://github.com/llvm/llvm-project/commit/2052c653614d58b100ee467c13a1630035e6cb8b
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-11-10 (Sun, 10 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp
    M mlir/test/Analysis/test-dominance.mlir
    M mlir/test/lib/IR/TestDominance.cpp

  Log Message:
  -----------
  [mlir][IR] Fix inconsistency in block/op dominance

An operation is considered to properly dominate itself in a graph region. That's because there is no concept of "dominance" in a graph region. (`dominates` returns "true" for all pairs of ops in the same block.)

Previously, a block was *not* considered to dominate itself in a graph region. This commit fixes thise asymmetry between ops and blocks: both are now properly dominating themselves in a graph region.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications