[all-commits] [llvm/llvm-project] ae4fc8: [RISCV] When using global merging, don't enable me...

[Alex Bradbury via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae4fc80574cfbbf2b2b53f2728cd785db76e9e69
      https://github.com/llvm/llvm-project/commit/ae4fc80574cfbbf2b2b53f2728cd785db76e9e69
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2024-11-09 (Sat, 09 Nov 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVTargetMachine.cpp
    M llvm/test/CodeGen/RISCV/global-merge-minsize-smalldata-nonzero.ll
    M llvm/test/CodeGen/RISCV/global-merge-minsize-smalldata-zero.ll
    M llvm/test/CodeGen/RISCV/global-merge-minsize.ll
    M llvm/test/CodeGen/RISCV/global-merge-offset.ll
    M llvm/test/CodeGen/RISCV/global-merge.ll

  Log Message:
  -----------
  [RISCV] When using global merging, don't enable merging of external globals by default (#115484)

AArch64 left this disabled after seeing some cases of slightly worse
codegen that weren't tracked down, so I suggest as a path to
incrementally moving towards enable globals merging we follow suit, and
evaluate turning on later.

This patch disables merging of external globals, but also adds a flag to
override that. This reduces churn in test cases, simplifies benchmarking
runs, and this flag can be removed later.

A follow-on PR enables the globals merging pass by default (and as it's
based on this commit, merging of external globals is disabled just as
they are for AArch64).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications