[all-commits] [llvm/llvm-project] 7a6a52: [SandboxIR] Remove incorrect assertion. (#115553)

Jorge Gorbe Moya via All-commits all-commits at lists.llvm.org
Fri Nov 8 14:14:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a6a52a2f0c6af63f210562d4a0345232d30d54d
      https://github.com/llvm/llvm-project/commit/7a6a52a2f0c6af63f210562d4a0345232d30d54d
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M llvm/lib/SandboxIR/Instruction.cpp

  Log Message:
  -----------
  [SandboxIR] Remove incorrect assertion. (#115553)

`insertBefore` can be called on a detached instruction, and we can't
check that the underlying instructions are ordered because instructions
without BB parents have no order.

This problem showed up as a different assertion failure in
`llvm::Instruction::comesBefore` in one of the unit tests when
`EXPENSIVE_CHECKS` are enabled.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list