[all-commits] [llvm/llvm-project] 26e5b4: [mlir][IR] `DominanceInfo`: Deduplicate `properlyD...

Matthias Springer via All-commits all-commits at lists.llvm.org
Thu Nov 7 23:15:30 PST 2024


  Branch: refs/heads/users/matthias-springer/dominance_deduplicate
  Home:   https://github.com/llvm/llvm-project
  Commit: 26e5b4f79d80b7302cec65f33fe3f0e2ddd8aed3
      https://github.com/llvm/llvm-project/commit/26e5b4f79d80b7302cec65f33fe3f0e2ddd8aed3
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp

  Log Message:
  -----------
  [mlir][IR] `DominanceInfo`: Deduplicate `properlyDominates` implementation

The implementations of `DominanceInfo::properlyDominates` and `PostDominanceInfo::properlyPostDominates` are almost identical: only one line of code is different. Define the function in `DominanceInfoBase` to avoid the code duplication.

Note: This commit is not marked as NFC because `PostDominanceInfo::properlyPostDominates` now also has an `enclosingOpOk` argument.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list