[all-commits] [llvm/llvm-project] e8c5e2: [mlir][IR] Fix inconsistency in block/op dominance

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/properly_dominate
  Home:   https://github.com/llvm/llvm-project
  Commit: e8c5e298de5bfb8c724e8c2b52e8dd1fe0f87f30
      https://github.com/llvm/llvm-project/commit/e8c5e298de5bfb8c724e8c2b52e8dd1fe0f87f30
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M mlir/include/mlir/IR/Dominance.h
    M mlir/lib/IR/Dominance.cpp

  Log Message:
  -----------
  [mlir][IR] Fix inconsistency in block/op dominance

An operation is considered to properly dominate itself in a graph region. That's because there is no concept of "dominance" in a graph region. (`dominates` returns "true" for all pairs of ops in the same block.)

Previously, a block was *not* considered to dominate itself in a graph region. This commit fixes thise asymmetry between ops and blocks: both are now properly dominating themselves in a graph region.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications