[all-commits] [llvm/llvm-project] 037f80: [RISCV][GISel] Add fcopysign tests with mismatched...

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Nov 7 17:07:53 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 037f8044f69f88101620707af1db948e6804e080
      https://github.com/llvm/llvm-project/commit/037f8044f69f88101620707af1db948e6804e080
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
    M llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/fp-arith-f16.mir
    M llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/fp-arith.mir
    M llvm/test/CodeGen/RISCV/GlobalISel/legalizer/legalize-fp-arith-f16.mir
    M llvm/test/CodeGen/RISCV/GlobalISel/legalizer/legalize-fp-arith.mir
    M llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/fp-arith-f16.mir
    M llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/fp-arith.mir

  Log Message:
  -----------
  [RISCV][GISel] Add fcopysign tests with mismatched types. NFC (#115364)

fcopysign takes two operands, one for the magnitude and exponent and the
other for the sign. The result type is determined by the magnitude and
exponent operand. The sign operand does not need to be the same type.
Note, in IR all 3 types must match.

We have isel patterns for all possible combinations of types and the
legalizer thinks they are all legal, but we had no tests for it. I was
unable to find any combiner rules that would create an instruction with
mismatch types.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list