[all-commits] [llvm/llvm-project] e40a31: [analyzer][NFC] Remove check::BranchCondition from...

[Donát Nagy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e40a31b7baef8c39b9e03ebf94ddfefdba52601e
      https://github.com/llvm/llvm-project/commit/e40a31b7baef8c39b9e03ebf94ddfefdba52601e
  Author: Donát Nagy <donat.nagy at ericsson.com>
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/TraversalChecker.cpp
    R clang/test/Analysis/traversal-algorithm.mm

  Log Message:
  -----------
  [analyzer][NFC] Remove check::BranchCondition from debug.DumpTraversal (#113906)

This commit removes the `check::BranchCondition` callback of the debug
checker `debug.DumpTraversal` (in `TraversalChecker.cpp`) and the single
broken testcase that was referring to it.

The testcase `traversal-algorithm.mm` was added in 2012 to verify that
we're using DFS traversal -- however it failed to detect that we're no
longer using DFS traversal and in fact it continues to pass even if I
remove large random portions of its code.

This change was motivated by the plan discussed at

https://discourse.llvm.org/t/fixing-or-removing-check-branchcondition/82738

I also added some TODO notes to mark the rest of `TraversalChecker.cpp`
for removal in follow-up commits.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications