[all-commits] [llvm/llvm-project] 1469d8: Remove `br i1 undef` from some regression tests [N...

Thu Nov 7 00:11:36 PST 2024

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1469d82e1cb3edc939d6b93089046edfef0cf36c
      https://github.com/llvm/llvm-project/commit/1469d82e1cb3edc939d6b93089046edfef0cf36c
  Author: Lee Wei <lee10202013 at gmail.com>
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
    M llvm/test/Analysis/BasicAA/phi-values-usage.ll
    M llvm/test/Analysis/BasicAA/underlying-value.ll
    M llvm/test/Analysis/BlockFrequencyInfo/irreducible_loop_crash.ll
    M llvm/test/Analysis/BranchProbabilityInfo/deopt-invoke.ll
    M llvm/test/Analysis/BranchProbabilityInfo/loop.ll
    M llvm/test/Analysis/BranchProbabilityInfo/unreachable.ll
    M llvm/test/Analysis/CostModel/SystemZ/intrinsic-cost-crash.ll
    M llvm/test/Analysis/CycleInfo/basic.ll
    M llvm/test/Analysis/CycleInfo/unreachable-predecessor.ll
    M llvm/test/Analysis/Delinearization/type_mismatch.ll
    M llvm/test/Analysis/Delinearization/undef.ll
    M llvm/test/Analysis/DependenceAnalysis/MIVCheckConst.ll
    M llvm/test/Analysis/DependenceAnalysis/NonAffineExpr.ll
    M llvm/test/Analysis/Dominators/basic.ll
    M llvm/test/Analysis/Dominators/print-dot-dom.ll
    M llvm/test/Analysis/MemoryDependenceAnalysis/invariant.group-bug.ll
    M llvm/test/Analysis/MemorySSA/cyclicphi.ll
    M llvm/test/Analysis/MemorySSA/debugvalue.ll
    M llvm/test/Analysis/MemorySSA/debugvalue2.ll
    M llvm/test/Analysis/MemorySSA/forward-unreachable.ll
    M llvm/test/Analysis/MemorySSA/function-clobber.ll
    M llvm/test/Analysis/MemorySSA/invariant-groups.ll
    M llvm/test/Analysis/MemorySSA/loop-rotate-disablebasicaa.ll
    M llvm/test/Analysis/MemorySSA/loop-rotate-simplified-clone.ll
    M llvm/test/Analysis/MemorySSA/loop-rotate-valuemap.ll
    M llvm/test/Analysis/MemorySSA/phi-translation.ll
    M llvm/test/Analysis/MemorySSA/pr28880.ll
    M llvm/test/Analysis/MemorySSA/pr40749_2.ll
    M llvm/test/Analysis/MemorySSA/pr41640.ll
    M llvm/test/Analysis/MemorySSA/pr41853.ll
    M llvm/test/Analysis/MemorySSA/pr42940.ll
    M llvm/test/Analysis/MemorySSA/pr43317.ll
    M llvm/test/Analysis/MemorySSA/pr43320.ll
    M llvm/test/Analysis/MemorySSA/pr43427.ll
    M llvm/test/Analysis/MemorySSA/pr43438.ll
    M llvm/test/Analysis/MemorySSA/pr43493.ll
    M llvm/test/Analysis/MemorySSA/pr43541.ll
    M llvm/test/Analysis/MemorySSA/pr43641.ll
    M llvm/test/Analysis/MemorySSA/pr45976.ll
    M llvm/test/Analysis/MemorySSA/reduce_clobber_limit.ll
    M llvm/test/Analysis/MemorySSA/renamephis.ll
    M llvm/test/Analysis/MemorySSA/unreachable.ll
    M llvm/test/Analysis/MemorySSA/update_unroll.ll
    M llvm/test/Analysis/PhiValues/basic.ll
    M llvm/test/Analysis/PhiValues/long_phi_chain.ll
    M llvm/test/Analysis/PostDominators/pr6047_a.ll
    M llvm/test/Analysis/PostDominators/pr6047_b.ll
    M llvm/test/Analysis/PostDominators/pr6047_c.ll
    M llvm/test/Analysis/PostDominators/pr6047_d.ll
    M llvm/test/Analysis/ScalarEvolution/2011-04-26-FoldAddRec.ll
    M llvm/test/Analysis/ScalarEvolution/SolveQuadraticEquation.ll
    M llvm/test/Analysis/ScalarEvolution/avoid-infinite-recursion-0.ll
    M llvm/test/Analysis/ScalarEvolution/avoid-infinite-recursion-1.ll
    M llvm/test/Analysis/ScalarEvolution/different-loops-recs.ll
    M llvm/test/Analysis/ScalarEvolution/expander-replace-congruent-ivs.ll
    M llvm/test/Analysis/ScalarEvolution/how-far-to-zero.ll
    M llvm/test/Analysis/ScalarEvolution/overflow-intrinsics-trip-count.ll
    M llvm/test/Analysis/ScalarEvolution/pointer-sign-bits.ll
    M llvm/test/Analysis/ScalarEvolution/pr22674.ll
    M llvm/test/Analysis/ScalarEvolution/pr22856.ll
    M llvm/test/Analysis/ScalarEvolution/pr25369.ll
    M llvm/test/Analysis/ScalarEvolution/scev-aa.ll
    M llvm/test/Analysis/ScalarEvolution/scev-canonical-mode.ll
    M llvm/test/Analysis/ScalarEvolution/scev-invalid.ll
    M llvm/test/Analysis/ScalarEvolution/shift-recurrences.ll
    M llvm/test/Analysis/ValueTracking/memory-dereferenceable.ll
    M llvm/test/Assembler/atomicrmw.ll
    M llvm/test/Assembler/convergence-control.ll
    M llvm/test/Bitcode/convergence-control.ll
    M llvm/test/DebugInfo/ARM/illegal-fragment.ll
    M llvm/test/DebugInfo/ARM/machine-cp-updates-dbg-reg.mir
    M llvm/test/DebugInfo/MIR/InstrRef/follow-spill-of-live-value.mir
    M llvm/test/DebugInfo/MIR/InstrRef/out-of-scope-blocks.mir
    M llvm/test/DebugInfo/MIR/X86/machine-cse.mir
    M llvm/test/DebugInfo/X86/dbg-merge-loc-entry.ll
    M llvm/test/DebugInfo/X86/dbg-value-terminator.ll
    M llvm/test/DebugInfo/X86/deleted-bit-piece.ll
    M llvm/test/DebugInfo/X86/earlydup-crash.ll
    M llvm/test/DebugInfo/X86/live-debug-values-constprop.mir
    M llvm/test/DebugInfo/X86/mem2reg_fp80.ll
    M llvm/test/DebugInfo/X86/sdag-dbgvalue-phi-use-4.ll
    M llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg2-dead-block-order.ll
    M llvm/test/Other/loop-pass-ordering.ll
    M llvm/test/Other/loopnest-pass-ordering.ll
    M llvm/test/Other/opt-bisect-new-pass-manager.ll
    M llvm/test/SafepointIRVerifier/from-same-relocation-in-phi-nodes.ll
    M llvm/test/SafepointIRVerifier/unrecorded-live-at-sp.ll
    M llvm/test/SafepointIRVerifier/uses-in-phi-nodes.ll
    M llvm/test/Verifier/tbaa-cyclic.ll
    M llvm/test/tools/llvm-reduce/operands-skip.ll

  Log Message:
  -----------
  Remove `br i1 undef` from some regression tests [NFC] (#115130)

As defined in LangRef, branching on `undef` is undefined behavior.
This PR aims to remove undefined behavior from tests. As UB tests break
Alive2 and may be the root cause of breaking future optimizations.

Here's an Alive2 proof for one of the examples:
https://alive2.llvm.org/ce/z/TncxhP

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications