[all-commits] [llvm/llvm-project] 13b589: [SelectionDAGBuilder][X86] Don't form FMAXNUM for ...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 13b5899c2904ba6b1f5223bf86679d046212da98
      https://github.com/llvm/llvm-project/commit/13b5899c2904ba6b1f5223bf86679d046212da98
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    A llvm/test/CodeGen/X86/pr114520.ll

  Log Message:
  -----------
  [SelectionDAGBuilder][X86] Don't form FMAXNUM for f16 vectors if FMAXNUM needs to be promoted. (#114943)

In #70357, I changed a isLegalOrCustom to isLegalOrCustomOrPromote in
visitSelect to enable integer min/max to be formed when the operation
was promoted. Unfortunately, this also affected floating point. For
floating point, fmaxnum may require a libcall so we also need to check
if the operation on the promoted type is legal or custom.

Other changes to RISC-V have seen made the original change untested so
this patch restores the original isLegalOrCustom.

Fixes #114520.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications