[all-commits] [llvm/llvm-project] 803f95: Fix a thinko in the CallSite handling code: (#114896)

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 803f957e87e4083f6d61c8991171eeeaf0e6bd61
      https://github.com/llvm/llvm-project/commit/803f957e87e4083f6d61c8991171eeeaf0e6bd61
  Author: jimingham <jingham at apple.com>
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
    M lldb/source/Symbol/CompileUnit.cpp
    A lldb/test/API/functionalities/breakpoint/same_cu_name/Makefile
    A lldb/test/API/functionalities/breakpoint/same_cu_name/TestFileBreakpoinsSameCUName.py
    A lldb/test/API/functionalities/breakpoint/same_cu_name/common.cpp
    A lldb/test/API/functionalities/breakpoint/same_cu_name/main.cpp

  Log Message:
  -----------
  Fix a thinko in the CallSite handling code: (#114896)

I have to check for the sc list size being changed by the call-site
search, not just that it had more than one element.

Added a test for multiple CU's with the same name in a given module,
which would have caught this mistake.

We were also doing all the work to find call sites when the found decl
and specified decl's only difference was a column, but the incoming
specification hadn't specified a column (column number == 0).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications