[all-commits] [llvm/llvm-project] 910a73: [X86] Make POP imply pointer-size operands, as wit...

[LIU Hao via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 910a73f3aa56388028d87e319862580daaf03152
      https://github.com/llvm/llvm-project/commit/910a73f3aa56388028d87e319862580daaf03152
  Author: LIU Hao <lh_mouse at 126.com>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    M llvm/test/MC/X86/intel-syntax-ambiguous.s
    M llvm/test/MC/X86/intel-syntax-ptr-sized.s

  Log Message:
  -----------
  [X86] Make POP imply pointer-size operands, as with PUSH for Intel syntax (#114533)

On x86-32 the word PUSH (50+rd) and POP (58+rd) instructions assume only
32-bit operands, and on x86-64 they assume only 64-bit operands; in
neither case should the absence of an operand size be ambiguous.

Those special case were added in
f6fb78089060818b4352b540abc44da4f62b95ef and lacking of POP seemed an
oversight.

This closes https://github.com/llvm/llvm-project/issues/114531.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications