[all-commits] [llvm/llvm-project] d3d810: [OpenMP] Using `SimpleVLA` to handle vla usage in ...

[Daniel Chen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3d8103d533280f322383e35cf5a9fe3075e236c
      https://github.com/llvm/llvm-project/commit/d3d8103d533280f322383e35cf5a9fe3075e236c
  Author: Daniel Chen <cdchen at ca.ibm.com>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M openmp/runtime/src/ompt-general.cpp

  Log Message:
  -----------
  [OpenMP] Using `SimpleVLA` to handle vla usage in ompt-general.cpp. (#114583)

The `openmp` runtime failed to build on LoP with LLVM18 on LoP due to
the addition of `-Wvla-cxx-extension` as
```
llvm-project/openmp/runtime/src/ompt-general.cpp:711:15: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
  711 |   int tmp_ids[ids_size];
      |               ^~~~~~~~
llvm-project/openmp/runtime/src/ompt-general.cpp:711:15: note: function parameter 'ids_size' with unknown value cannot be used in a constant expression
llvm-project/openmp/runtime/src/ompt-general.cpp:704:65: note: declared here
  704 | OMPT_API_ROUTINE int ompt_get_place_proc_ids(int place_num, int ids_size,
      |                                                                 ^
1 error generated.
```

This patch is to ignore the checking against this usage.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications