[all-commits] [llvm/llvm-project] acd04c: [libc][cmake] disable include tests in overlay mod...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Fri Nov 1 15:01:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: acd04c2e1861dda155ca0244b5d74141a2c036b8
      https://github.com/llvm/llvm-project/commit/acd04c2e1861dda155ca0244b5d74141a2c036b8
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M libc/test/CMakeLists.txt
    M libc/test/include/CMakeLists.txt

  Log Message:
  -----------
  [libc][cmake] disable include tests in overlay mode (#114566)

This avoids -Wmacro-redefinition diagnostics observed when building the
libc_include_tests ninja target.

For example, the signbit_test will attempt to include BOTH our math-macros.h
(via math-function-macros.h), and the system's math.h (via hdr/math_macros.h).

While it's nice that we can get some coverage of the headers we will provide to
end users of fullbuilds in CI of overlay builds, it's not worth chasing each
individual conflict and disabling some include tests as conflicts arise.

Disable the include tests unless `-DLLVM_LIBC_FULL_BUILD=ON` is specified.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list