[all-commits] [llvm/llvm-project] 841227: Re-apply "Revert "[JITLink] Use MapVector to stabi...

[Lang Hames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 841227a5d9326dd99fb8ac8d26ded9a3c56dd46d
      https://github.com/llvm/llvm-project/commit/841227a5d9326dd99fb8ac8d26ded9a3c56dd46d
  Author: Lang Hames <lhames at gmail.com>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
    M llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
    M llvm/test/ExecutionEngine/JITLink/x86-64/COFF_comdat_associative_dead_strip.test
    M llvm/test/ExecutionEngine/JITLink/x86-64/COFF_pdata_strip.s

  Log Message:
  -----------
  Re-apply "Revert "[JITLink] Use MapVector to stabilize iteration.."" with fixes.

This re-applies 244ea406259, which was reverted in 0019d061854 while I
investigated a bot failure. The fix for the failure will be committed as a
follow-up.


  Commit: f04aaf948204068276f57dbcba5734c53382c7e2
      https://github.com/llvm/llvm-project/commit/f04aaf948204068276f57dbcba5734c53382c7e2
  Author: Lang Hames <lhames at gmail.com>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/ELFNixPlatform.cpp

  Log Message:
  -----------
  [ORC][ELF] Process .init_array sections in priority order.

Fixes compiler-rt/test/orc/TestCases/Linux/x86-64/priority-static-initializer.S
testcase after 244ea406259. This testcase had been succeeding because the
definition order of the .init_array sections in the testcase matched their
priorities, but began failing once 244ea406259 removed that guarantee. The
proper fix is to visit the .init_array sections according to their priority
order, regardless of how they're defined in the file.

This fixes the single-file testcase, but I think that ELFNixPlatform will need
to be extended to make priorities work correctly across file boundaries.


Compare: https://github.com/llvm/llvm-project/compare/b278fe329755...f04aaf948204

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications