[all-commits] [llvm/llvm-project] 466b58: [flang] Avoid generating duplicate symbol in comda...

[Valentin Clement (バレンタイン クレメン) via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 466b58ba3809efa4c82e950a62065b58b8c696bd
      https://github.com/llvm/llvm-project/commit/466b58ba3809efa4c82e950a62065b58b8c696bd
  Author: Valentin Clement (バレンタイン クレメン) <clementval at gmail.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp
    A flang/test/Fir/comdat-present.fir

  Log Message:
  -----------
  [flang] Avoid generating duplicate symbol in comdat (#114472)

In case where a fir.global might be duplicated in an inner module
(gpu.module), the conversion pattern will be applied on the module and
the gpu module version of the global and try to generate multiple comdat
with the same symbol name. This is what we have in the implementation of
CUDA Fortran.

Just check for the presence of the `ComdatSelectorOp` before creating a
new one.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications