[all-commits] [llvm/llvm-project] 5c1752: [MLIR][DLTI] Pretty parsing and printing for DLTI ...

[Rolf Morel via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c1752e368585e55c0335a7d7651fe43d42af282
      https://github.com/llvm/llvm-project/commit/5c1752e368585e55c0335a7d7651fe43d42af282
  Author: Rolf Morel <rolf.morel at intel.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M flang/test/Fir/tco-default-datalayout.fir
    M flang/test/Fir/tco-explicit-datalayout.fir
    M mlir/include/mlir/Dialect/DLTI/DLTIAttrs.td
    M mlir/include/mlir/Interfaces/DataLayoutInterfaces.h
    M mlir/include/mlir/Interfaces/DataLayoutInterfaces.td
    M mlir/lib/Dialect/DLTI/DLTI.cpp
    M mlir/lib/Interfaces/DataLayoutInterfaces.cpp
    M mlir/test/Dialect/DLTI/invalid.mlir
    M mlir/test/Dialect/DLTI/query.mlir
    M mlir/test/Dialect/DLTI/roundtrip.mlir
    M mlir/test/Dialect/DLTI/valid.mlir
    M mlir/test/Dialect/GPU/outlining.mlir
    M mlir/test/Target/LLVMIR/Import/data-layout.ll
    M mlir/unittests/Interfaces/DataLayoutInterfacesTest.cpp

  Log Message:
  -----------
  [MLIR][DLTI] Pretty parsing and printing for DLTI attrs (#113365)

Unifies parsing and printing for DLTI attributes. Introduces a format of
`#dlti.attr<key1 = val1, ..., keyN = valN>` syntax for all queryable
DLTI attributes similar to that of the DictionaryAttr, while retaining
support for specifying key-value pairs with `#dlti.dl_entry` (whether to
retain this is TBD).

As the new format does away with most of the boilerplate, it is much easier
to parse for humans. This makes an especially big difference for nested
attributes.

Updates the DLTI-using tests and includes fixes for misc error checking/
error messages.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications