[all-commits] [llvm/llvm-project] a1c6dc: [llvm][docs] Add Approvals section to GitHub guide...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1c6dc223ee1eedc049890676992b508ebd6b623
      https://github.com/llvm/llvm-project/commit/a1c6dc223ee1eedc049890676992b508ebd6b623
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M llvm/docs/CodeReview.rst
    M llvm/docs/GitHub.rst

  Log Message:
  -----------
  [llvm][docs] Add Approvals section to GitHub guide (#113434)

Based on feedback that when reading the document as a guide, it's odd
that it skips right from updating the PR to merging it.

The section is a link to the existing Code Review guide's text on the
topic.

I have updated that to mention required reviewers, which some
subprojects do use (libcxx is one) but most don't.

Also we use the words "accepted" and "approved" interchangeably, so I've
swapped one instance so it's consistent between paragraphs.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications