[all-commits] [llvm/llvm-project] b27db9: [OpenMP][MLIR] Descriptor explicit member map lowe...

agozillon via All-commits all-commits at lists.llvm.org
Wed Oct 30 10:53:39 PDT 2024


  Branch: refs/heads/users/agozillo/alloca-member-map-2
  Home:   https://github.com/llvm/llvm-project
  Commit: b27db9198dedd284ea24161dc4fe6fcb3952814b
      https://github.com/llvm/llvm-project/commit/b27db9198dedd284ea24161dc4fe6fcb3952814b
  Author: agozillon <Andrew.Gozillon at amd.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Dialect/OpenMP/ops.mlir
    R mlir/test/Target/LLVMIR/omptarget-fortran-allocatable-types-host.mlir
    A mlir/test/Target/LLVMIR/omptarget-nested-ptr-record-type-mapping-host.mlir
    M mlir/test/Target/LLVMIR/omptarget-nested-record-type-mapping-host.mlir
    A mlir/test/Target/LLVMIR/omptarget-record-type-with-ptr-member-host.mlir

  Log Message:
  -----------
  [OpenMP][MLIR] Descriptor explicit member map lowering changes

This is one of 3 PRs in a PR stack that aims to add support for explicit mapping of
allocatable members in derived types.

The primary changes in this PR are the OpenMPToLLVMIRTranslation.cpp changes,
which are small and seek to alter the current member mapping to add an
additional map insertion for pointers. Effectively, if the member is a pointer
(currently indicated by having a varPtrPtr field) we add an additional map for
the pointer and then alter the subsequent mapping of the member (the data)
to utilise the member rather than the parents base pointer. This appears to be
necessary in certain cases when mapping pointer data within record types to
avoid segfaulting on device (due to incorrect data mapping). In general this
record type mapping may be simplifiable in the future.

There are also additions of tests which should help to showcase the affect
of the changes above.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list