[all-commits] [llvm/llvm-project] 6f973f: [AMDGPU][test] fix the error case in update_mc_tes...

Brox Chen via All-commits all-commits at lists.llvm.org
Wed Oct 30 06:03:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6f973fd4ab18ff58689e83383190ed4767c2a7dd
      https://github.com/llvm/llvm-project/commit/6f973fd4ab18ff58689e83383190ed4767c2a7dd
  Author: Brox Chen <guochen2 at amd.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm_err.s
    M llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm_err.s.expected
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_mc_test_checks.py

  Log Message:
  -----------
  [AMDGPU][test] fix the error case in update_mc_test_check script (#112731)

update_mc_test_check script handle the "error case testline" wrong in
three cases:

1. when user select "--llvm-mc-binary" with a path, the script does not
add "not" on top of the "--llvm-mc-binary" and thus getting non-zero
exit code and failed.
2. When "not" is presented in runline while not all testlines are
expected to fail, the script need to check if the "not" is needed when
it execute llvm-mc line by line. Otherwise the script will fail on
testline which is passing.
3. When there are multiple runlines, the error checkline need to use
correct line offset for "[[LINE-X]]"

This patch solve these three issues



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list