[all-commits] [llvm/llvm-project] e8b7f5: [TableGen] Remove a pointless check for iPTRAny

Jessica Clarke via All-commits all-commits at lists.llvm.org
Tue Oct 29 20:20:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8b7f53fa4dc8a9f74a3d67dfb89eb68fcd78679
      https://github.com/llvm/llvm-project/commit/e8b7f53fa4dc8a9f74a3d67dfb89eb68fcd78679
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp

  Log Message:
  -----------
  [TableGen] Remove a pointless check for iPTRAny

We've already called EnforceInteger on Types[0], and iPTRAny isn't
regarded as an integer type (note that TableGen special-cases iPTR here
to include that, though), so we cannot possibly still have an iPTRAny by
this point. Delete the check, and let getFixedSizeInBits catch it along
with all the other overloaded types if that ever becomes false. Also
document why we have this check whilst here.

Reviewers: arsenm

Reviewed By: arsenm

Pull Request: https://github.com/llvm/llvm-project/pull/113732



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list