[all-commits] [llvm/llvm-project] 950ee7: [RISC-V] Fix check of minimum vlen. (#114055)

[Harald van Dijk via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 950ee75909d94c582ecac4d3d559c364ed88244f
      https://github.com/llvm/llvm-project/commit/950ee75909d94c582ecac4d3d559c364ed88244f
  Author: Harald van Dijk <harald.vandijk at codeplay.com>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
    M llvm/test/CodeGen/RISCV/rvv/allocate-lmul-2-4-8.ll

  Log Message:
  -----------
  [RISC-V] Fix check of minimum vlen. (#114055)

If we have a minimum vlen, we were adjusting StackSize to change the
unit from vscale to bytes, and then calculating the required padding
size for alignment in bytes. However, we then used that padding size as
an offset in vscale units, resulting in misplaced stack objects.

While it would be possible to adjust the object offsets by dividing
AlignmentPadding by ST.getRealMinVLen() / RISCV::RVVBitsPerBlock, we can
simplify the calculation a bit if instead we adjust the alignment to be
in vscale units.

@topperc This fixes a bug I am seeing after #110312, but I am not 100%
certain I am understanding the code correctly, could you please see if
this makes sense to you?



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications