[all-commits] [llvm/llvm-project] a388df: [XRay] Remove reliance on default PIC behavior in ...

[Sebastian Kreutzer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a388df712700f38ad9a51d49a657a28e739f5eb4
      https://github.com/llvm/llvm-project/commit/a388df712700f38ad9a51d49a657a28e739f5eb4
  Author: Sebastian Kreutzer <SebastianKreutzer at gmx.net>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M clang/test/Driver/XRay/xray-shared.cpp
    M compiler-rt/test/xray/TestCases/Posix/clang-xray-shared.cpp

  Log Message:
  -----------
  [XRay] Remove reliance on default PIC behavior in DSO tests (#113892)

Compiling with `-fxray-shared` requires position-independent code
(introduced in #113548).
Some tests do not explicitly specify this, thus falling back to the
compiler default.
If, for example, Clang is compiled with
`-DCLANG_DEFAULT_PIE_ON_LINUX=OFF`, these checks fail.

This patch addresses this issue in two tests:
- Removing a check in `xray-shared.cpp` that only tests default PIC
behavior
- Adding `-fPIC` explicitly in `clang-xray-shared.cpp`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications