[all-commits] [llvm/llvm-project] 658807: [mlir][func] Fix incorrect API usage in `FuncOpCon...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6588073724d3241d90663e45154d806a28bce95a
      https://github.com/llvm/llvm-project/commit/6588073724d3241d90663e45154d806a28bce95a
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp

  Log Message:
  -----------
  [mlir][func] Fix incorrect API usage in `FuncOpConversion` (#113977)

This commit fixes a case of incorrect dialect conversion API usage
during `FuncOpConversion`. `replaceAllUsesExcept` (same as
`replaceAllUsesWith`) is currently not supported in a dialect
conversion. `replaceUsesOfBlockArgument` should be used instead. It
sometimes works anyway (like in this case), but that's just because of
the way we insert materializations.

This commit is in preparation of merging the 1:1 and 1:N dialect
conversion drivers. (At that point, the current use of
`replaceAllUsesExcept` will no longer work.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications