[all-commits] [llvm/llvm-project] 9653e6: [mlir][func] Fix incorrect API usage in `FuncOpCon...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/func_byval
  Home:   https://github.com/llvm/llvm-project
  Commit: 9653e6bc77cbca3627e9ef2165d15bbf9a66ac94
      https://github.com/llvm/llvm-project/commit/9653e6bc77cbca3627e9ef2165d15bbf9a66ac94
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp

  Log Message:
  -----------
  [mlir][func] Fix incorrect API usage in `FuncOpConversion`

This commit fixes a case of incorrect dialect conversion API usage during `FuncOpConversion`. `replaceAllUsesExcept` (same as `replaceAllUsesWith`) is currently not supported in a dialect conversion. `replaceUsesOfBlockArgument` should be used instead. It sometimes works anyway (like in this case), but that's just because of the way we insert materializations.

This commit is in preparation of merging the 1:1 and 1:N dialect conversion drivers. (At that point, the current use of `replaceAllUsesExcept` will no longer work.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications