[all-commits] [llvm/llvm-project] e47bf3: [JIT] Fix crash in unit tests

[Kai Nacke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e47bf3d08d51306f2e534951a1b77043dc540ceb
      https://github.com/llvm/llvm-project/commit/e47bf3d08d51306f2e534951a1b77043dc540ceb
  Author: Kai Nacke <kai.peter.nacke at ibm.com>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h

  Log Message:
  -----------
  [JIT] Fix crash in unit tests

The unit tests `ReOptimizeLayerTest.BasicReOptimization` and `JITLinkRedirectionManagerTest.BasicRedirectionOperation` are failing for me with the error:

```
Program aborted due to an unhandled Error:
Error value was Success. (Note: Success values must still be checked prior to being destroyed).
```

The error is raised when a value is assigned to `Err`, due to the the missing `ErrorAsOutParameter`.

The fix is to move the error handling out of the constructor.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications