[all-commits] [llvm/llvm-project] 2d26ef: [lldb-dap][test] Set disableASLR to False for test...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d26ef09fc87472cd42ea219c8f9267599872958
      https://github.com/llvm/llvm-project/commit/2d26ef09fc87472cd42ea219c8f9267599872958
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py

  Log Message:
  -----------
  [lldb-dap][test] Set disableASLR to False for tests (#113593)

When running in constrained environments like docker, disabling ASLR
might fail with errors like:
```
AssertionError: False is not true : launch failed (Cannot launch
'/__w/.../lldb-dap/stackTrace/subtleFrames/TestDAP_subtleFrames.test_subtleFrames/a.out':
personality set failed: Operation not permitted)
```
E.g., https://github.com/llvm/llvm-project/pull/110303

Hence we already run `settings set target.disable-aslr false` as part of
the init-commands for the non-DAP tests (see
https://github.com/llvm/llvm-project/pull/88312 and
https://discourse.llvm.org/t/running-lldb-in-a-container/76801).

But we never adjusted it for the DAP tests. As a result we get
conflicting test logs like:
```
 {
    "arguments": {
      "commandEscapePrefix": null,
      "disableASLR": true,
     ....
      "initCommands": [
        ...
        "settings set target.disable-aslr false",
```

Disabling ASLR by default in tests isn't useulf (it's only really a
debugging aid for users). So this patch sets `disableASLR=False` by
default.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications