[all-commits] [llvm/llvm-project] b852fb: [lldb] Move ValueObject into its own library (NFC)...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Oct 24 20:21:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b852fb1ec5fa15f0b913cc4988cbd09239b19904
      https://github.com/llvm/llvm-project/commit/b852fb1ec5fa15f0b913cc4988cbd09239b19904
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    M lldb/include/lldb/Core/IOHandler.h
    R lldb/include/lldb/Core/ValueObject.h
    R lldb/include/lldb/Core/ValueObjectCast.h
    R lldb/include/lldb/Core/ValueObjectChild.h
    R lldb/include/lldb/Core/ValueObjectConstResult.h
    R lldb/include/lldb/Core/ValueObjectConstResultCast.h
    R lldb/include/lldb/Core/ValueObjectConstResultChild.h
    R lldb/include/lldb/Core/ValueObjectConstResultImpl.h
    R lldb/include/lldb/Core/ValueObjectDynamicValue.h
    R lldb/include/lldb/Core/ValueObjectList.h
    R lldb/include/lldb/Core/ValueObjectMemory.h
    R lldb/include/lldb/Core/ValueObjectRegister.h
    R lldb/include/lldb/Core/ValueObjectSyntheticFilter.h
    R lldb/include/lldb/Core/ValueObjectUpdater.h
    R lldb/include/lldb/Core/ValueObjectVTable.h
    R lldb/include/lldb/Core/ValueObjectVariable.h
    M lldb/include/lldb/DataFormatters/FormattersContainer.h
    M lldb/include/lldb/DataFormatters/TypeFormat.h
    M lldb/include/lldb/DataFormatters/TypeSynthetic.h
    M lldb/include/lldb/Expression/ExpressionVariable.h
    M lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h
    M lldb/include/lldb/Target/LanguageRuntime.h
    M lldb/include/lldb/Target/StackFrame.h
    M lldb/include/lldb/Target/StackFrameRecognizer.h
    A lldb/include/lldb/ValueObject/ValueObject.h
    A lldb/include/lldb/ValueObject/ValueObjectCast.h
    A lldb/include/lldb/ValueObject/ValueObjectChild.h
    A lldb/include/lldb/ValueObject/ValueObjectConstResult.h
    A lldb/include/lldb/ValueObject/ValueObjectConstResultCast.h
    A lldb/include/lldb/ValueObject/ValueObjectConstResultChild.h
    A lldb/include/lldb/ValueObject/ValueObjectConstResultImpl.h
    A lldb/include/lldb/ValueObject/ValueObjectDynamicValue.h
    A lldb/include/lldb/ValueObject/ValueObjectList.h
    A lldb/include/lldb/ValueObject/ValueObjectMemory.h
    A lldb/include/lldb/ValueObject/ValueObjectRegister.h
    A lldb/include/lldb/ValueObject/ValueObjectSyntheticFilter.h
    A lldb/include/lldb/ValueObject/ValueObjectUpdater.h
    A lldb/include/lldb/ValueObject/ValueObjectVTable.h
    A lldb/include/lldb/ValueObject/ValueObjectVariable.h
    M lldb/source/API/CMakeLists.txt
    M lldb/source/API/SBBlock.cpp
    M lldb/source/API/SBFrame.cpp
    M lldb/source/API/SBModule.cpp
    M lldb/source/API/SBTarget.cpp
    M lldb/source/API/SBThread.cpp
    M lldb/source/API/SBType.cpp
    M lldb/source/API/SBValue.cpp
    M lldb/source/API/SBValueList.cpp
    M lldb/source/Breakpoint/BreakpointLocation.cpp
    M lldb/source/Breakpoint/CMakeLists.txt
    M lldb/source/Breakpoint/Watchpoint.cpp
    M lldb/source/CMakeLists.txt
    M lldb/source/Commands/CMakeLists.txt
    M lldb/source/Commands/CommandObjectDWIMPrint.cpp
    M lldb/source/Commands/CommandObjectFrame.cpp
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Commands/CommandObjectThread.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Core/CMakeLists.txt
    M lldb/source/Core/DumpRegisterValue.cpp
    M lldb/source/Core/FormatEntity.cpp
    M lldb/source/Core/IOHandlerCursesGUI.cpp
    R lldb/source/Core/ValueObject.cpp
    R lldb/source/Core/ValueObjectCast.cpp
    R lldb/source/Core/ValueObjectChild.cpp
    R lldb/source/Core/ValueObjectConstResult.cpp
    R lldb/source/Core/ValueObjectConstResultCast.cpp
    R lldb/source/Core/ValueObjectConstResultChild.cpp
    R lldb/source/Core/ValueObjectConstResultImpl.cpp
    R lldb/source/Core/ValueObjectDynamicValue.cpp
    R lldb/source/Core/ValueObjectList.cpp
    R lldb/source/Core/ValueObjectMemory.cpp
    R lldb/source/Core/ValueObjectRegister.cpp
    R lldb/source/Core/ValueObjectSyntheticFilter.cpp
    R lldb/source/Core/ValueObjectUpdater.cpp
    R lldb/source/Core/ValueObjectVTable.cpp
    R lldb/source/Core/ValueObjectVariable.cpp
    M lldb/source/DataFormatters/CMakeLists.txt
    M lldb/source/DataFormatters/CXXFunctionPointer.cpp
    M lldb/source/DataFormatters/DumpValueObjectOptions.cpp
    M lldb/source/DataFormatters/FormatManager.cpp
    M lldb/source/DataFormatters/StringPrinter.cpp
    M lldb/source/DataFormatters/TypeSummary.cpp
    M lldb/source/DataFormatters/ValueObjectPrinter.cpp
    M lldb/source/DataFormatters/VectorType.cpp
    M lldb/source/Expression/CMakeLists.txt
    M lldb/source/Expression/FunctionCaller.cpp
    M lldb/source/Expression/IRInterpreter.cpp
    M lldb/source/Expression/LLVMUserExpression.cpp
    M lldb/source/Expression/Materializer.cpp
    M lldb/source/Expression/UserExpression.cpp
    M lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp
    M lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp
    M lldb/source/Plugins/ABI/AArch64/CMakeLists.txt
    M lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp
    M lldb/source/Plugins/ABI/ARC/CMakeLists.txt
    M lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp
    M lldb/source/Plugins/ABI/ARM/ABISysV_arm.cpp
    M lldb/source/Plugins/ABI/ARM/CMakeLists.txt
    M lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.cpp
    M lldb/source/Plugins/ABI/Hexagon/CMakeLists.txt
    M lldb/source/Plugins/ABI/MSP430/ABISysV_msp430.cpp
    M lldb/source/Plugins/ABI/MSP430/CMakeLists.txt
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp
    M lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp
    M lldb/source/Plugins/ABI/Mips/CMakeLists.txt
    M lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp
    M lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp
    M lldb/source/Plugins/ABI/PowerPC/CMakeLists.txt
    M lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp
    M lldb/source/Plugins/ABI/RISCV/CMakeLists.txt
    M lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp
    M lldb/source/Plugins/ABI/SystemZ/CMakeLists.txt
    M lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.cpp
    M lldb/source/Plugins/ABI/X86/ABISysV_i386.cpp
    M lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp
    M lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp
    M lldb/source/Plugins/ABI/X86/CMakeLists.txt
    M lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionUtil.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    M lldb/source/Plugins/InstrumentationRuntime/TSan/CMakeLists.txt
    M lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp
    M lldb/source/Plugins/InstrumentationRuntime/UBSan/CMakeLists.txt
    M lldb/source/Plugins/InstrumentationRuntime/UBSan/InstrumentationRuntimeUBSan.cpp
    M lldb/source/Plugins/InstrumentationRuntime/Utility/CMakeLists.txt
    M lldb/source/Plugins/InstrumentationRuntime/Utility/ReportRetriever.cpp
    M lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt
    M lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
    M lldb/source/Plugins/Language/CPlusPlus/Coroutines.h
    M lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.h
    M lldb/source/Plugins/Language/CPlusPlus/Generic.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxx.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxList.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.h
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp
    M lldb/source/Plugins/Language/ObjC/CF.cpp
    M lldb/source/Plugins/Language/ObjC/CF.h
    M lldb/source/Plugins/Language/ObjC/CMakeLists.txt
    M lldb/source/Plugins/Language/ObjC/Cocoa.cpp
    M lldb/source/Plugins/Language/ObjC/Cocoa.h
    M lldb/source/Plugins/Language/ObjC/CoreMedia.h
    M lldb/source/Plugins/Language/ObjC/NSArray.cpp
    M lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
    M lldb/source/Plugins/Language/ObjC/NSDictionary.h
    M lldb/source/Plugins/Language/ObjC/NSError.cpp
    M lldb/source/Plugins/Language/ObjC/NSException.cpp
    M lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp
    M lldb/source/Plugins/Language/ObjC/NSSet.cpp
    M lldb/source/Plugins/Language/ObjC/NSSet.h
    M lldb/source/Plugins/Language/ObjC/NSString.cpp
    M lldb/source/Plugins/Language/ObjC/NSString.h
    M lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/CMakeLists.txt
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt
    M lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/CMakeLists.txt
    M lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp
    M lldb/source/Plugins/MemoryHistory/asan/CMakeLists.txt
    M lldb/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp
    M lldb/source/Plugins/OperatingSystem/Python/CMakeLists.txt
    M lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
    M lldb/source/Plugins/Platform/Android/CMakeLists.txt
    M lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
    M lldb/source/Plugins/Platform/POSIX/CMakeLists.txt
    M lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
    M lldb/source/Plugins/Process/Utility/CMakeLists.txt
    M lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp
    M lldb/source/Plugins/SystemRuntime/MacOSX/AbortWithPayloadFrameRecognizer.cpp
    M lldb/source/Plugins/SystemRuntime/MacOSX/CMakeLists.txt
    M lldb/source/Symbol/CMakeLists.txt
    M lldb/source/Symbol/Variable.cpp
    M lldb/source/Target/ABI.cpp
    M lldb/source/Target/CMakeLists.txt
    M lldb/source/Target/StackFrame.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Target.cpp
    M lldb/source/Target/Thread.cpp
    M lldb/source/Target/ThreadPlanStepOut.cpp
    A lldb/source/ValueObject/CMakeLists.txt
    A lldb/source/ValueObject/ValueObject.cpp
    A lldb/source/ValueObject/ValueObjectCast.cpp
    A lldb/source/ValueObject/ValueObjectChild.cpp
    A lldb/source/ValueObject/ValueObjectConstResult.cpp
    A lldb/source/ValueObject/ValueObjectConstResultCast.cpp
    A lldb/source/ValueObject/ValueObjectConstResultChild.cpp
    A lldb/source/ValueObject/ValueObjectConstResultImpl.cpp
    A lldb/source/ValueObject/ValueObjectDynamicValue.cpp
    A lldb/source/ValueObject/ValueObjectList.cpp
    A lldb/source/ValueObject/ValueObjectMemory.cpp
    A lldb/source/ValueObject/ValueObjectRegister.cpp
    A lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
    A lldb/source/ValueObject/ValueObjectUpdater.cpp
    A lldb/source/ValueObject/ValueObjectVTable.cpp
    A lldb/source/ValueObject/ValueObjectVariable.cpp
    M lldb/unittests/ValueObject/CMakeLists.txt
    M lldb/unittests/ValueObject/DumpValueObjectOptionsTests.cpp

  Log Message:
  -----------
  [lldb] Move ValueObject into its own library (NFC) (#113393)

ValueObject is part of lldbCore for historical reasons, but conceptually
it deserves to be its own library. This does introduce a (link-time) circular
dependency between lldbCore and lldbValueObject, which is unfortunate
but probably unavoidable because so many things in LLDB rely on
ValueObject. We already have cycles and these libraries are never built
as dylibs so while this doesn't improve the situation, it also doesn't
make things worse.

The header includes were updated with the following command:

```
find . -type f -exec sed -i.bak "s%include \"lldb/Core/ValueObject%include \"lldb/ValueObject/ValueObject%" '{}' \;
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list