[all-commits] [llvm/llvm-project] 2e686d: [libc++] Remove workaround which allows setting _L...

[Nikolas Klauser via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e686d6d17c4cc7608510a856055e6ca79fcb917
      https://github.com/llvm/llvm-project/commit/2e686d6d17c4cc7608510a856055e6ca79fcb917
  Author: Nikolas Klauser <nikolasklauser at berlin.de>
  Date:   2024-10-24 (Thu, 24 Oct 2024)

  Changed paths:
    M libcxx/include/__config

  Log Message:
  -----------
  [libc++] Remove workaround which allows setting _LIBCPP_OVERRIDABLE_FUNC_VIS externally (#113139)

`-fvisibility-global-new-delete` has been added in Clang 18, so there is
no more need to specify the visibility of new/delete via libc++-internal
macros.

Some people used a custom new/delete, which requires them to have
default visibility, but didn't want to leak any symbols otherwise. Since
the new/delete visibility can now be controlled by a compiler flag,
there is no reason to set it with out macro.

https://reviews.llvm.org/D128007 originally tried to remove the option
to override the macro, but was partially reverted because people
actually set this specific macro.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications