[all-commits] [llvm/llvm-project] 1b0fcf: [clang-tidy][NFC] Replace usages of `DeclSpec::TQ`...

[Vlad Serebrennikov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b0fcf1e42e05611ec37aa7956988ae6317ad116
      https://github.com/llvm/llvm-project/commit/1b0fcf1e42e05611ec37aa7956988ae6317ad116
  Author: Vlad Serebrennikov <serebrennikov.vladislav at gmail.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
    M clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp
    M clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
    M clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
    M clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp
    M clang-tools-extra/clang-tidy/utils/FixItHintUtils.h
    M clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp

  Log Message:
  -----------
  [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (#113295)

This patch improves, but doens't fully resolve the layering violation,
which stems from relying on Sema. There's one function that needs to
convert enumerator to a string (`buildQualifier` in
`FixItHintUtils.cpp`), but `Qualifiers::TQ` doesn't offer such function.
Even more, the set of enumerators is not complete compared to
`DeclSpec::TQ`, so I'm afraid that this would be a functional change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications