[all-commits] [llvm/llvm-project] 2ccbea: [dsymutil] Share one BinaryHolder between debug ma...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Tue Oct 22 09:40:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ccbea1d738332cd92d8d33fdd51dfac3482328e
      https://github.com/llvm/llvm-project/commit/2ccbea1d738332cd92d8d33fdd51dfac3482328e
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M llvm/tools/dsymutil/DebugMap.cpp
    M llvm/tools/dsymutil/DebugMap.h
    M llvm/tools/dsymutil/MachODebugMapParser.cpp
    M llvm/tools/dsymutil/dsymutil.cpp
    M llvm/tools/dsymutil/dsymutil.h

  Log Message:
  -----------
  [dsymutil] Share one BinaryHolder between debug map parsing & linking (#113234)

I (re)discovered that dsymutil was instantiating two BinaryHolders: one
for parsing the debug map and one for linking. That really defeats the
purpose of the BinaryHolder as it serves as a cache. Fix the issue and
remove an old FIXME.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list