[all-commits] [llvm/llvm-project] 2074de: [clang][HIP] Don't use the OpenCLKernel CC when ta...

Alex Voicu via All-commits all-commits at lists.llvm.org
Tue Oct 22 09:17:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2074de252b59a82279c275a1c8e7a4be6e1101d8
      https://github.com/llvm/llvm-project/commit/2074de252b59a82279c275a1c8e7a4be6e1101d8
  Author: Alex Voicu <alexandru.voicu at amd.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M clang/lib/CodeGen/CGDeclCXX.cpp
    M clang/lib/Sema/SemaType.cpp
    M clang/test/CodeGenCUDA/device-init-fun.cu
    M clang/test/CodeGenCUDA/kernel-amdgcn.cu

  Log Message:
  -----------
  [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (#110447)

When compiling HIP source for AMDGCN flavoured SPIR-V that is expected
to be consumed by the ROCm HIP RT, it's not desirable to set the OpenCL
Kernel CC on `__global__` functions. On one hand, this is not an OpenCL
RT, so it doesn't compose with e.g. OCL specific attributes. On the
other it is a "noisy" CC that carries semantics, and breaks overload
resolution when using [generic dispatchers such as those used by
RAJA](https://github.com/LLNL/RAJAPerf/blob/186d4194a5719788ae96631c923f9ca337f56970/src/common/HipDataUtils.hpp#L39).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list