[all-commits] [llvm/llvm-project] 6e0b00: [clang][OpenCL][CodeGen][AMDGPU] Do not use `priva...

[Alex Voicu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e0b0038cd65ce726ce404305a06e1cf33e36cca
      https://github.com/llvm/llvm-project/commit/6e0b0038cd65ce726ce404305a06e1cf33e36cca
  Author: Alex Voicu <alexandru.voicu at amd.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/CodeGen/CGBlocks.cpp
    M clang/lib/CodeGen/CGBuiltin.cpp
    M clang/test/CodeGenOpenCL/addr-space-struct-arg.cl
    M clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl
    M clang/test/CodeGenOpenCL/amdgpu-abi-struct-arg-byref.cl
    M clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl
    M clang/test/CodeGenOpenCL/amdgpu-nullptr.cl
    M clang/test/CodeGenOpenCL/atomic-ops.cl
    M clang/test/CodeGenOpenCL/atomics-unsafe-hw-remarks-gfx90a.cl
    M clang/test/CodeGenOpenCL/blocks.cl
    M clang/test/CodeGenOpenCL/builtins-alloca.cl
    M clang/test/CodeGenOpenCL/builtins-amdgcn-gfx12.cl
    M clang/test/CodeGenOpenCL/builtins-amdgcn-gfx940.cl
    M clang/test/CodeGenOpenCL/builtins-fp-atomics-gfx12.cl
    M clang/test/CodeGenOpenCL/builtins-fp-atomics-gfx8.cl
    M clang/test/CodeGenOpenCL/builtins-fp-atomics-gfx90a.cl
    M clang/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl
    M clang/test/CodeGenOpenCL/opencl_types.cl
    M clang/test/Index/pipe-size.cl

  Log Message:
  -----------
  [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (#112442)

Currently, for AMDGPU, when compiling for OpenCL, we unconditionally use
`private` as the default address space. This is wrong for cases where
the `generic` address space is available, and is corrected via this
patch. In general, this AS map abuse is a bad hack and we should re-work
it altogether, but at least after this patch we will stop being
incorrect for e.g. OpenCL 2.0.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications