[all-commits] [llvm/llvm-project] 8ae39c: [MC] Fix llvm-mc unterminated string constants war...

[Daniel Paoliello via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ae39c8e34de2d24c46827b324c76bac845c18b0
      https://github.com/llvm/llvm-project/commit/8ae39c8e34de2d24c46827b324c76bac845c18b0
  Author: Daniel Paoliello <danpao at microsoft.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M llvm/lib/MC/MCParser/AsmParser.cpp

  Log Message:
  -----------
  [MC] Fix llvm-mc unterminated string constants warning for Windows (#112995)

#98060 introduced a warning for unterminated string constants, however
it was only checking for `\n` which means that it produced strange
results on Windows (always blaming column 1) including having the
[associated test
fail](https://buildkite.com/llvm-project/github-pull-requests/builds/111277#0192a122-c5c9-4e4e-bc5b-7532fec99ae4)
if Git happened to use Windows newlines when creating the file.

This fix for this is to detect both `\r` and `\n`, but don't double-warn
for Windows newlines.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications