[all-commits] [llvm/llvm-project] 120e42: [MemProf] Improve metadata cleanup in LTO backend ...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 120e42d3135f558b5e0a73da1c6484571eeff941
      https://github.com/llvm/llvm-project/commit/120e42d3135f558b5e0a73da1c6484571eeff941
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
    M llvm/test/ThinLTO/X86/memprof-icp.ll

  Log Message:
  -----------
  [MemProf] Improve metadata cleanup in LTO backend (#113039)

Previously we were attempting to remove the memprof-related metadata
when iterating through instructions in the LTO backend. However, we
missed some as there are a number of cases where we skip instructions,
or even entire functions. Simplify the cleanup and ensure all is removed
by doing a full sweep over all instructions after completing cloning.

This is largely NFC except with -memprof-report-hinted-sizes enabled,
because we were propagating and simplifying the metadata after inlining
in the LTO backend, which caused some stray messages as metadata was
re-converted to attributes.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications