[all-commits] [llvm/llvm-project] 46dc91: [SystemZ][z/OS] Add new openFileForReadBinary func...

Abhina Sree via All-commits all-commits at lists.llvm.org
Mon Oct 21 05:20:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 46dc91e7d9a1b6dd0144e628519d06954b7b4e53
      https://github.com/llvm/llvm-project/commit/46dc91e7d9a1b6dd0144e628519d06954b7b4e53
  Author: Abhina Sree <Abhina.Sreeskantharajan at ibm.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M clang/include/clang/Basic/FileManager.h
    M clang/include/clang/Basic/FileSystemStatCache.h
    M clang/lib/Basic/FileManager.cpp
    M clang/lib/Basic/FileSystemStatCache.cpp
    M clang/lib/Lex/HeaderMap.cpp
    M clang/lib/Lex/PPDirectives.cpp
    M clang/lib/Serialization/ASTReader.cpp
    A clang/test/Preprocessor/embed_zos.c
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/Support/VirtualFileSystem.cpp

  Log Message:
  -----------
  [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (#111723)

This patch adds an IsText parameter to the following getBufferForFile,
getBufferForFileImpl. We introduce a new virtual function
openFileForReadBinary which defaults to openFileForRead except in
RealFileSystem which uses the OF_None flag instead of OF_Text.

The default is set to OF_Text instead of OF_None, this change in value
does not affect any other platforms other than z/OS. Setting this
parameter correctly is required to open files on z/OS in the correct
encoding. The IsText parameter is based on the context of where we open
files, for example, in the ASTReader, HeaderMap requires that files
always be opened in binary even though they might be tagged as text.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list