[all-commits] [llvm/llvm-project] 697a45: More aggressively deduplicate global warnings base...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 697a455e6fecf364c1ac4ff9874aefddf2952454
      https://github.com/llvm/llvm-project/commit/697a455e6fecf364c1ac4ff9874aefddf2952454
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2024-10-19 (Sat, 19 Oct 2024)

  Changed paths:
    M lldb/include/lldb/Core/Module.h
    M lldb/source/Core/Module.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    A lldb/test/Shell/SymbolFile/DWARF/TestDedupWarnings.test

  Log Message:
  -----------
  More aggressively deduplicate global warnings based on contents.  (#112801)

I've been getting complaints from users being spammed by -gmodules
missing file warnings going out of control because each object file
depends on an entire DAG of PCM files that usually are all missing at
once. To reduce this problem, this patch does two things:

1. Module now maintains a DenseMap<hash, once> that is used to display
each warning only once, based on its actual text.

2. The PCM warning itself is reworded to include less details, such as
the DIE offset, which is only useful to LLDB developers, who can get
this from the dwarf log if they need it. Because the detail is omitted
the hashing from (1) deduplicates the warnings.

rdar://138144624



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications