[all-commits] [llvm/llvm-project] faed85: [lldb][test][NFC] Document DYLIB_NAME Makefile var...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: faed85b8e4961e853bfb10cd8ed1544e179ade0a
      https://github.com/llvm/llvm-project/commit/faed85b8e4961e853bfb10cd8ed1544e179ade0a
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-10-19 (Sat, 19 Oct 2024)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/make/Makefile.rules

  Log Message:
  -----------
  [lldb][test][NFC] Document DYLIB_NAME Makefile variable (#112735)

Got caught out by this because simply specifying `DYLIB_CXX_SOURCES`
(without specifying `DYLIB_NAME`) resulted in linker errors because the
dylib was never built (and linked). We should probably make that a
Makefile error (though I haven't audited when exactly not specifying
`DYLIB_NAME` is valid; looked like that can happen when we specify
`FRAMEWORK`).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications