[all-commits] [llvm/llvm-project] 0a3347: [mlir][linalg] Fix idx comparison in the vectorize...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a3347dc638594bef802d8148a77052c198ec27b
      https://github.com/llvm/llvm-project/commit/0a3347dc638594bef802d8148a77052c198ec27b
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/test/Dialect/Linalg/vectorize-tensor-extract.mlir

  Log Message:
  -----------
  [mlir][linalg] Fix idx comparison in the vectorizer (#112900)

Fixes loop comparison condition in the vectorizer.

As that logic is used specifically for vectorising `tensor.extract`, I
also added a test that violates the assumptions made inside
`getTrailingNonUnitLoopDimIdx`, namely that Linalg loops are non-empty.
Vectorizer pre-conditions will capture that much earlier making sure
that `getTrailingNonUnitLoopDimIdx` is only run when all the assumptions
are actually met.

Thank you for pointing this out, @pfusik !



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications