[all-commits] [llvm/llvm-project] 8f6d49: [llvm][TableGen] Count implicit defs as well as ex...

JL2210 via All-commits all-commits at lists.llvm.org
Fri Oct 18 02:51:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f6d4913bbc4ad9ba9c139b8ce6dd69058435d17
      https://github.com/llvm/llvm-project/commit/8f6d4913bbc4ad9ba9c139b8ce6dd69058435d17
  Author: JL2210 <larrowe.semaj11 at gmail.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    A llvm/test/TableGen/GlobalISelEmitter-implicit-defs.td
    M llvm/utils/TableGen/GlobalISelEmitter.cpp

  Log Message:
  -----------
  [llvm][TableGen] Count implicit defs as well as explicit ones in the GlobalISel TableGen emitter (#112673)

`NumDefs` only counts the number of registers in `(outs)`, not any
implicit defs specified with `Defs = [...]`

This causes patterns with physical register defs to fail to import here
instead of later where implicit defs are rendered.

Add on `ImplicitDefs.size()` to count both and create `DstExpDefs` to
count only explicit defs, used later on.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list