[all-commits] [llvm/llvm-project] 0a53f4: [utils] support "Reverts ${PR}" in commit messages...

George Burgess IV via All-commits all-commits at lists.llvm.org
Wed Oct 16 14:39:57 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a53f43c0c7e33cde07b24169e8f45db7eba2fea
      https://github.com/llvm/llvm-project/commit/0a53f43c0c7e33cde07b24169e8f45db7eba2fea
  Author: George Burgess IV <george.burgess.iv at gmail.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M llvm/utils/revert_checker.py
    M llvm/utils/revert_checker_test.py

  Log Message:
  -----------
  [utils] support "Reverts ${PR}" in commit messages (#112226)

A bisection in ChromeOS ended at a reverted commit, which wasn't flagged
by this revert checking script, since it used `Reverts ${PR}` rather
than `This reverts commit ${SHA}`.

`grep` says that somewhere around 400 reverts in the last year have used
`Reverts ${PR}` syntax. Support it.

Tested in part by running the command that was expected to catch this
revert:

```
$ ./revert_checker.py -C ~/llvm/main/ \
    3b5e7c83a6e226d5bd7ed2e9b67449b64812074c origin/main \
    | grep -q 4b0276d1c9cb558f3c20736dce802ceb26c0b958
$ echo $?
0
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list