[all-commits] [llvm/llvm-project] 37ad65: [mlir][arith] Remove some e2e tests (#112012)

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 37ad65ffb6b8b8867e5d58f05ba676211d0da233
      https://github.com/llvm/llvm-project/commit/37ad65ffb6b8b8867e5d58f05ba676211d0da233
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir
    R mlir/test/Integration/Dialect/Arith/CPU/addition.mlir
    R mlir/test/Integration/Dialect/Arith/CPU/comparison.mlir
    R mlir/test/Integration/Dialect/Arith/CPU/multiplication.mlir

  Log Message:
  -----------
  [mlir][arith] Remove some e2e tests (#112012)

I am removing the recently added integration test for various Arith Ops.
These operations and their lowerings are effectively already verified by
the Arith-to-LLVM conversion tests in:
  * "mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir"

I've noticed that a few variants of `arith.cmpi` were missing in that
file - those are added here as well.

This is a follow-up for this discussion:
  * https://github.com/llvm/llvm-project/pull/92272

See also the recent update to our guidelines on e2e tests in MLIR:
  * https://github.com/llvm/mlir-www/pull/203



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications