[all-commits] [llvm/llvm-project] 97da5e: [GSYM] Remove redundant getInliningInfoForAddress ...

[David Stenberg via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 97da5e670099848f7d136a6988afd6ea638e2210
      https://github.com/llvm/llvm-project/commit/97da5e670099848f7d136a6988afd6ea638e2210
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp

  Log Message:
  -----------
  [GSYM] Remove redundant getInliningInfoForAddress call (#111136)

In DwarfTransformer::verify() line number information is retrieved for
each address using:

  auto DwarfInlineInfos =
      DICtx.getInliningInfoForAddress(SectAddr, DLIS);

Later down the loop, another such invocation was made before:

  Gsym->dump(Log, *FI);

There is a continue after that, DwarfInlineInfos do not affect the
dump() invocation, I am not aware of any other side effects that is
needed from the extra getInliningInfoForAddress() invocation, and tests
pass without it, so just remove it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications