[all-commits] [llvm/llvm-project] 46200f: [libc] fix -Wmissing-attributes in setjmp (#112415)

[Nick Desaulniers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 46200fcf941d16bc8a494a3915e1178502e37a3e
      https://github.com/llvm/llvm-project/commit/46200fcf941d16bc8a494a3915e1178502e37a3e
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M libc/src/setjmp/setjmp_impl.h
    M libc/src/setjmp/x86_64/setjmp.cpp

  Log Message:
  -----------
  [libc] fix -Wmissing-attributes in setjmp (#112415)

Fixes:

    llvm-project/libc/src/setjmp/x86_64/setjmp.cpp:21:25: error: ‘int
    __llvm_libc_19_0_0_git::setjmp(__jmp_buf*)’ specifies less restrictive
    attribute than its target ‘int
    __llvm_libc_19_0_0_git::__setjmp_impl__(__jmp_buf*)’: ‘nothrow’
    [-Werror=missing-attributes]
       21 | LLVM_LIBC_FUNCTION(int, setjmp, (__jmp_buf * buf)) {
          |                         ^~~~~~

observed in the GCC build by manually expanding LLVM_LIBC_FUNCTION to add
`gnu::nothrow` to the alias.

We probably need to revisit adding nothrow throughout our declarations, so
there is probably a better way to clean this up in the future.

Link: #88054



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications