[all-commits] [llvm/llvm-project] a4367d: [lldb] Support tests with nested make invocations ...

[Stefan Gränitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a4367d2d136420f562f64e7731b9393fb609f3fc
      https://github.com/llvm/llvm-project/commit/a4367d2d136420f562f64e7731b9393fb609f3fc
  Author: Stefan Gränitz <stefan.graenitz at gmail.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M lldb/test/API/functionalities/completion/Makefile

  Log Message:
  -----------
  [lldb] Support tests with nested make invocations on Windows 1/2 (#112342)

In recent PR https://github.com/llvm/llvm-project/pull/111531 for
Windows support, we enabled tests that require the `make` tool. On
Windows, default install directories likely contain spaces, in this case
e.g. `C:\Program Files (x86)\GnuWin32\bin\make.exe`. It's typically
handled well by CMake, so that today invocations from `dotest.py` don't
cause issues. However, we also have nested invocations from a number of
Makefiles themselves. These still failed if the path to the `make` tool
contains spaces.

This patch attempts to fix the functionalities/completion test by adding
quotes in the respective Makefile. If it keeps passing on the bots, we can
roll out the fix to all affected tests.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications