[all-commits] [llvm/llvm-project] c1b206: [clang][python] Don't add check-clang-python to ch...

[Alex Bradbury via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1b206f347f633c84ac32f691241460196cd6226
      https://github.com/llvm/llvm-project/commit/c1b206f347f633c84ac32f691241460196cd6226
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2024-10-13 (Sun, 13 Oct 2024)

  Changed paths:
    M clang/bindings/python/tests/CMakeLists.txt

  Log Message:
  -----------
  [clang][python] Don't add check-clang-python to check-all if cross-compiling (#111657)

Consistent with other cases for these tests, we opt not to add the
target to check-all if they're known to fail. The tests fail when cross
compiling for a different architecture because the host
Python3_EXECUTABLE is used to run them, and FFI calls will of course
fail against the libraries compiled for the target.

Do note that CMAKE_CROSSCOMPILING is set to true whenever CMAKE_SYSTEM_NAME was set manually <https://cmake.org/cmake/help/latest/variable/CMAKE_CROSSCOMPILING.html> so in some circumstances it may be set even when not cross-compiling. However, it's the best way of checking that CMake has right now, and we use it elsewhere in LLVM's build system.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications