[all-commits] [llvm/llvm-project] 9a696b: Revert "[NVPTX] Prefer prmt.b32 over bfi.b32 (#110...

Emilio Cota via All-commits all-commits at lists.llvm.org
Fri Oct 11 05:43:00 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9a696b68b735fa01276d16d39370f9102fee4a0b
      https://github.com/llvm/llvm-project/commit/9a696b68b735fa01276d16d39370f9102fee4a0b
  Author: Emilio Cota <ecg at google.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
    M llvm/test/CodeGen/NVPTX/i8x4-instructions.ll
    M llvm/test/CodeGen/NVPTX/sext-setcc.ll

  Log Message:
  -----------
  Revert "[NVPTX] Prefer prmt.b32 over bfi.b32 (#110766)"

This reverts commit 3f9998af4f79e95fe8be615df9d6b898008044b9.

It breaks downstream tests with egregious numerical differences.

Unfortunately no upstream tests are broken, but the fact that
a prior iteration of the commit (pre-optimization) does work
with our downstream tests (coming from the Triton repo) supports
the claim that the final version of the commit is incorrect.

Reverting now so that the original author can evaluate.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list