[all-commits] [llvm/llvm-project] 4f3207: Revert "[lldb] skip ReverseContinue tests on Darwin"

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f320778148ba481881eb53ba065ed2a9d9bbc03
      https://github.com/llvm/llvm-project/commit/4f320778148ba481881eb53ba065ed2a9d9bbc03
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
    M lldb/test/API/functionalities/reverse-execution/TestReverseContinueNotSupported.py

  Log Message:
  -----------
  Revert "[lldb] skip ReverseContinue tests on Darwin"

This reverts commit c686eeb7fcc89673909e7e1f0a0a09a0da269d28.


  Commit: a28e7ce378d717e6aacbdc3089974b93b6b62948
      https://github.com/llvm/llvm-project/commit/a28e7ce378d717e6aacbdc3089974b93b6b62948
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

  Log Message:
  -----------
  Revert "[lldb] SetErrorStringWithFormatv -> FromErrorStringWithFormatv (NFC)"

This reverts commit fae7d6848bbb59fc2bad17adbdb34bd6a11a0651.


  Commit: 3bef742559f1556569423ec63c70b97dff1d426e
      https://github.com/llvm/llvm-project/commit/3bef742559f1556569423ec63c70b97dff1d426e
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/include/lldb/API/SBProcess.h
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/packages/Python/lldbsuite/test/gdbclientutils.py
    R lldb/packages/Python/lldbsuite/test/lldbgdbproxy.py
    R lldb/packages/Python/lldbsuite/test/lldbreverse.py
    M lldb/packages/Python/lldbsuite/test/lldbtest.py
    M lldb/source/API/SBProcess.cpp
    M lldb/source/API/SBThread.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
    M lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
    M lldb/source/Plugins/Process/scripted/ScriptedProcess.h
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Thread.cpp
    R lldb/test/API/functionalities/reverse-execution/Makefile
    R lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
    R lldb/test/API/functionalities/reverse-execution/TestReverseContinueNotSupported.py
    R lldb/test/API/functionalities/reverse-execution/main.c
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/LLDBUtils.cpp

  Log Message:
  -----------
  Revert "[lldb] Implement basic support for reverse-continue (#99736)"

Reverting this again; I added a commit which added @skipIfDarwin
markers to the TestReverseContinueBreakpoints.py and
TestReverseContinueNotSupported.py API tests, which use lldb-server
in gdbserver mode which does not work on Darwin.  But the aarch64 ubuntu
bot reported a failure on TestReverseContinueBreakpoints.py,
https://lab.llvm.org/buildbot/#/builders/59/builds/6397

  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 63, in test_reverse_continue_skip_breakpoint
    self.reverse_continue_skip_breakpoint_internal(async_mode=False)
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py", line 81, in reverse_continue_skip_breakpoint_internal
    self.expect(
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2372, in expect
    self.runCmd(
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1002, in runCmd
    self.assertTrue(self.res.Succeeded(), msg + output)
AssertionError: False is not true : Process should be stopped due to history boundary
Error output:
error: Process must be launched.

This reverts commit 4f297566b3150097de26c6a23a987d2bd5fc19c5.


Compare: https://github.com/llvm/llvm-project/compare/cc20dd285ab7...3bef742559f1

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications